Messages in this thread | | | Subject | Re: [PATCH v2] fix printk output | From | Sergei Ianovich <> | Date | Tue, 10 Dec 2013 11:29:34 +0400 |
| |
On Tue, 2013-12-10 at 15:59 +1030, Rusty Russell wrote: > Sergei Ianovich <ynvich@gmail.com> writes: > Hmm, the copy here is gratuitous. Using current->comm is safe, just > possibly ambigious if someone is changing the task name at the same time. > > And we really want this one line anyway: > > printk(KERN_WARNING > "%s: waiting module removal not supported: please upgrade\n", > current->comm);
I would put tool's name in the end for clarity. Message comes from the kernel and the kernel recommends to upgrade the tool. "%s: ..." could make the impression that the tool recommends to upgrade the kernel.
> BTW, did you actually hit this?
# modprobe usb_storage [ 600.807274] usbcore: registered new interface driver usb-storage # modprobe -r usb_storage [ 604.216318] waiting module removal not supported: please upgrade[ 604.222164] usbcore: deregistering interface driver usb-storage # modprobe -V kmod version 9
I am using the latest kmod package from emdebian unstable-grip.
| |