lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 35/41] tile: Replace __get_cpu_var uses
On Mon, 9 Dec 2013, Chris Metcalf wrote:

> Except for a comment typo:
>
> > /*
> > * Read the set of maskable interrupts.
> > - * We avoid the preemption warning here via __this_cpu_ptr since even
> > + * We avoid the preemption warning here via raw_cpu_ptr since even
> > * if irqs are already enabled, it's harmless to read the wrong cpu's
> > * enabled mask.
> > */
> > #define arch_local_irqs_enabled() \
> > - (*__this_cpu_ptr(&interrupts_enabled_mask))
> > + raw_cpu_read(interrupts_enabled_mask)
>
> Should be raw_cpu_read() in the comment.

Ok fixed.

> I assume you are planning to submit these through your own tree, not the arch trees?

Well once the core pieces are in then they can go through the arch trees.



\
 
 \ /
  Last update: 2013-12-10 16:41    [W:2.156 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site