Messages in this thread | | | Date | Tue, 10 Dec 2013 09:32:13 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v3 03/15] mfd: menelaus: Convert to threaded irq |
| |
On Mon, 09 Dec 2013, Felipe Balbi wrote:
> We don't need that extra workqueue when we have generic threaded irq > handlers support. This patch just moves over to threaded irqs and > deletes the unnecessary workqueue. > > Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi> > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > drivers/mfd/menelaus.c | 29 ++++------------------------- > 1 file changed, 4 insertions(+), 25 deletions(-)
<snip>
> - err = request_irq(client->irq, menelaus_irq, 0, > - DRIVER_NAME, menelaus); > + err = request_threaded_irq(client->irq, NULL, menelaus_irq, > + IRQF_ONESHOT, DRIVER_NAME, menelaus);
devm_* managed resources please.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |