| Date | Tue, 10 Dec 2013 10:35:18 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH v2 06/16] wl1251: configure hardware en-/decryption for monitor mode |
| |
Hi!
> --- a/drivers/net/wireless/ti/wl1251/tx.c > +++ b/drivers/net/wireless/ti/wl1251/tx.c > @@ -287,6 +287,9 @@ static int wl1251_tx_frame(struct wl1251 *wl, struct sk_buff *skb) > info = IEEE80211_SKB_CB(skb); > > if (info->control.hw_key) { > + if (unlikely(wl->monitor_present)) > + return -1; > +
This function seems to use 0/-errno convention. So probably "return -EINVAL"?
With that fixed:
Reviewed-by: Pavel Machek <pavel@ucw.cz>
Thanks, Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
|