lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/18] mm: numa: Ensure anon_vma is locked to prevent parallel THP splits
    Date
    The anon_vma lock prevents parallel THP splits and any associated complexity
    that arises when handling splits during THP migration. This patch checks
    if the lock was successfully acquired and bails from THP migration if it
    failed for any reason.

    Cc: stable@vger.kernel.org
    Signed-off-by: Mel Gorman <mgorman@suse.de>
    Reviewed-by: Rik van Riel <riel@redhat.com>
    ---
    mm/huge_memory.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/mm/huge_memory.c b/mm/huge_memory.c
    index 5a5da50..0f00b96 100644
    --- a/mm/huge_memory.c
    +++ b/mm/huge_memory.c
    @@ -1359,6 +1359,13 @@ int do_huge_pmd_numa_page(struct mm_struct *mm, struct vm_area_struct *vma,
    goto out_unlock;
    }

    + /* Bail if we fail to protect against THP splits for any reason */
    + if (unlikely(!anon_vma)) {
    + put_page(page);
    + page_nid = -1;
    + goto clear_pmdnuma;
    + }
    +
    /*
    * Migrate the THP to the requested node, returns with page unlocked
    * and pmd_numa cleared.
    --
    1.8.4


    \
     
     \ /
      Last update: 2013-12-11 13:41    [W:4.514 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site