Messages in this thread | | | Subject | Re: [PATCH] net: mac80211: tx.c: be sure of 'sdata->vif.type' must be NL80211_IFTYPE_AP when be in NL80211_IFTYPE_AP case | From | Johannes Berg <> | Date | Sun, 01 Dec 2013 10:37:27 +0100 |
| |
On Sun, 2013-12-01 at 07:48 +0800, Chen Gang wrote:
> If ieee80211_subif_start_xmit() is not performance sensitive (I guess > so), we can use some short static functions instead of some code blocks > within ieee80211_subif_start_xmit(). > > - ieee80211_subif_start_xmit() is a long function (600+ lines). > > - use short static function can share some code. > > - if code can be shared, the work flow can be more clearer too (don't > need fall-through or goto).
Frankly, I'm getting tired of discussing this. Please don't try to rewrite this code until you've understood it. You suggesting that "start_xmit()" isn't a performance sensitive function makes me realize you haven't even tried.
johannes
| |