lkml.org 
[lkml]   [2013]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 38/94] Revert "rt2x00pci: Use PCI MSIs whenever possible"
    Date
    3.11-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Stanislaw Gruszka <sgruszka@redhat.com>

    commit dfb6b7c109a7f98d324a759599d1b4616f02c79f upstream.

    This reverts commit 9483f40d8d01918b399b4e24d0c1111db0afffeb.

    Some devices stop to connect with above commit, see:
    https://bugzilla.kernel.org/show_bug.cgi?id=61621

    Since there is no clear benefit of having MSI enabled, just revert
    change to fix the problem.

    Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
    Acked-by: Jakub Kicinski <kubakici@wp.pl>
    Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/rt2x00/rt2x00pci.c | 9 +--------
    1 file changed, 1 insertion(+), 8 deletions(-)

    --- a/drivers/net/wireless/rt2x00/rt2x00pci.c
    +++ b/drivers/net/wireless/rt2x00/rt2x00pci.c
    @@ -105,13 +105,11 @@ int rt2x00pci_probe(struct pci_dev *pci_
    goto exit_release_regions;
    }

    - pci_enable_msi(pci_dev);
    -
    hw = ieee80211_alloc_hw(sizeof(struct rt2x00_dev), ops->hw);
    if (!hw) {
    rt2x00_probe_err("Failed to allocate hardware\n");
    retval = -ENOMEM;
    - goto exit_disable_msi;
    + goto exit_release_regions;
    }

    pci_set_drvdata(pci_dev, hw);
    @@ -152,9 +150,6 @@ exit_free_reg:
    exit_free_device:
    ieee80211_free_hw(hw);

    -exit_disable_msi:
    - pci_disable_msi(pci_dev);
    -
    exit_release_regions:
    pci_release_regions(pci_dev);

    @@ -179,8 +174,6 @@ void rt2x00pci_remove(struct pci_dev *pc
    rt2x00pci_free_reg(rt2x00dev);
    ieee80211_free_hw(hw);

    - pci_disable_msi(pci_dev);
    -
    /*
    * Free the PCI device data.
    */



    \
     
     \ /
      Last update: 2013-11-09 08:41    [W:4.068 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site