lkml.org 
[lkml]   [2013]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 5/5] OF: Introduce utility helper functions
On Fri, Nov 08, 2013 at 05:04:00PM +0200, Pantelis Antoniou wrote:
> Introduce helper functions for working with the live DT tree.
>
> __of_free_property() frees a dynamically created property
> __of_free_tree() recursively frees a device node tree
> __of_copy_property() copies a property dynamically
> __of_create_empty_node() creates an empty node
> __of_find_node_by_full_name() finds the node with the full name
> and
> of_multi_prop_cmp() performs a multi property compare but without
> having to take locks.
>
> Bug fix about prop->len == 0 by Ionut Nicu <ioan.nicu.ext@nsn.com>
>
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>

Hi Pantelis,

nitpick:

.git/rebase-apply/patch:77: trailing whitespace.
* no pointer exist for any properties. Only safe to do if you
.git/rebase-apply/patch:213: trailing whitespace.
* Find a node with the give full name by recursively following any of
.git/rebase-apply/patch:274: new blank line at EOF.
+
warning: 3 lines add whitespace errors.

Guenter


\
 
 \ /
  Last update: 2013-11-08 20:41    [W:0.037 / U:2.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site