lkml.org 
[lkml]   [2013]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: make reboot task only run on the appropriate processor
On 11/08/2013 07:14 AM, Vivek Goyal wrote:
>
> Hi Bao,
>
> This patch fixes the issue for me too. I noticed that we have generic
> function migrate_to_reboot_cpu() to achieve what we want and rest of
> the reboot paths are using it. So how about using that function. I
> wrote the new patch below. It works for me. Can you please give it
> a try.
>
> Thanks
> Vivek
>

Is this path exercised for the kdump flow? migrate_to_reboot_cpu() is
unsafe in that case.

> Index: linux-2.6/kernel/kexec.c
> ===================================================================
> --- linux-2.6.orig/kernel/kexec.c 2013-10-16 00:30:50.000000000 -0400
> +++ linux-2.6/kernel/kexec.c 2013-11-08 21:34:02.492072375 -0500
> @@ -1676,6 +1676,7 @@ int kernel_kexec(void)
> #endif
> {
> kernel_restart_prepare(NULL);
> + migrate_to_reboot_cpu();
> printk(KERN_EMERG "Starting new kernel\n");
> machine_shutdown();
> }
>



\
 
 \ /
  Last update: 2013-11-08 18:01    [W:0.132 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site