lkml.org 
[lkml]   [2013]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] printk: Defer printing to irq work when we printed too much
On Fri 08-11-13 00:46:49, Frederic Weisbecker wrote:
> On Thu, Nov 07, 2013 at 06:37:17PM -0500, Steven Rostedt wrote:
> > On Fri, 8 Nov 2013 00:21:51 +0100
> > Frederic Weisbecker <fweisbec@gmail.com> wrote:
> > >
> > > Offloading to a workqueue would be perhaps better, and writing to the serial
> > > console could then be done with interrupts enabled, preemptible context, etc...
> >
> > Oh God no ;-) Adding workqueue logic into printk just spells a
> > nightmare of much more complexity for a critical kernel infrastructure.
>
> But yeah that's scary, that means workqueues itself can't printk that safely.
> So, you're right after all.
Yeah, we've been there (that was actually my initial proposal). But
Andrew and Steven (rightfully) objected and suggested irq_work should be
used instead.

Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2013-11-08 11:41    [W:0.059 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site