Messages in this thread Patch in this message | | | Date | Thu, 7 Nov 2013 10:49:19 +0300 | From | Dan Carpenter <> | Subject | [patch] mailbox/omap: make mbox->irq signed for error handling |
| |
There is a bug in omap2_mbox_probe() where we try do:
mbox->irq = platform_get_irq(pdev, info->irq_id); if (mbox->irq < 0) {
The problem is that mbox->irq is unsigned so the error handling doesn't work. I've changed it to a signed integer.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/mailbox/omap-mbox.h b/drivers/mailbox/omap-mbox.h index 6cd38fc..86d7518 100644 --- a/drivers/mailbox/omap-mbox.h +++ b/drivers/mailbox/omap-mbox.h @@ -52,7 +52,7 @@ struct omap_mbox_queue { struct omap_mbox { const char *name; - unsigned int irq; + int irq; struct omap_mbox_queue *txq, *rxq; struct omap_mbox_ops *ops; struct device *dev;
| |