Messages in this thread Patch in this message | | | Date | Thu, 7 Nov 2013 16:43:11 +0000 | From | Christoph Lameter <> | Subject | [PATCH] kmod: Run usermodehelpers only on cpus allowed for kthreadd V2 |
| |
usermodehelper() threads can currently run on all processors. This is an issue for low latency cores. Spawnig a new thread causes cpu holdoffs in the range of hundreds of microseconds to a few milliseconds. Not good for cores on which processes run that need to react as fast as possible.
kthreadd threads can be restricted using taskset to a limited set of processors. Then the kernel thread pool will not fork processes on those anymore thereby protecting those processors from additional latencies.
Make usermodehelper() threads obey the limitations that kthreadd is restricted to. Kthreadd is not the parent of usermodehelper threads so we need to explicitly get the allowed processors for kthreadd.
Before this patch there is no way to limit the cpus that usermodehelper can run on since the affinity is set when the thread is spawned to all processors.
Signed-off-by: Christoph Lameter <cl@linux.com>
Index: linux/include/linux/kthread.h =================================================================== --- linux.orig/include/linux/kthread.h 2013-11-07 10:31:46.667807582 -0600 +++ linux/include/linux/kthread.h 2013-11-07 10:31:46.663807693 -0600 @@ -51,6 +51,7 @@ void kthread_parkme(void); int kthreadd(void *unused); extern struct task_struct *kthreadd_task; extern int tsk_fork_get_node(struct task_struct *tsk); +void set_kthreadd_affinity(void);
/* * Simple work processor based on kthread. Index: linux/kernel/kmod.c =================================================================== --- linux.orig/kernel/kmod.c 2013-11-07 10:31:46.667807582 -0600 +++ linux/kernel/kmod.c 2013-11-07 10:35:28.825645008 -0600 @@ -40,6 +40,7 @@ #include <linux/ptrace.h> #include <linux/async.h> #include <asm/uaccess.h> +#include <linux/kthread.h>
#include <trace/events/module.h>
@@ -209,8 +210,13 @@ static int ____call_usermodehelper(void flush_signal_handlers(current, 1); spin_unlock_irq(¤t->sighand->siglock);
- /* We can run anywhere, unlike our parent keventd(). */ - set_cpus_allowed_ptr(current, cpu_all_mask); + /* + * Kthreadd can be restricted to a set of processors if the user wants to + * protect other processors from OS latencies. If that has happened then + * we do not want to disturb the other processors here either so we start + * the usermode helper threads only on the processors allowed for kthreadd. + */ + set_kthreadd_affinity();
/* * Our parent is keventd, which runs with elevated scheduling priority. Index: linux/kernel/kthread.c =================================================================== --- linux.orig/kernel/kthread.c 2013-11-07 10:31:46.667807582 -0600 +++ linux/kernel/kthread.c 2013-11-07 10:31:46.667807582 -0600 @@ -136,6 +136,15 @@ void *kthread_data(struct task_struct *t return to_kthread(task)->data; }
+/* + * Set the affinity of the calling task to be the same + * as the kthreadd affinities. + */ +void set_kthreadd_affinity(void) +{ + set_cpus_allowed(current, kthreadd_task->cpus_allowed); +} + /** * probe_kthread_data - speculative version of kthread_data() * @task: possible kthread task in question
| |