Messages in this thread Patch in this message | | | Date | Thu, 7 Nov 2013 16:29:15 +0000 | From | Christoph Lameter <> | Subject | Re: [PATCH] mm/slub: Switch slub_debug kernel option to early_param to avoid boot panic |
| |
There is still something not optimal with the patch since it would disable debuggin on the kmalloc stack. Ccheck name for NULL only if slub_debug_slabs.
Subject: slub: Handle NULL parameter in kmem_cache_flags V2
V1->V2 - flags need to be applied regardless if !slub_debug_slabs
kmem_cache_flags may be called with NULL parameter during early boot. Skip the test in that case.
Signed-off-by: Christoph Lameter <cl@linux.com>
Index: linux/mm/slub.c =================================================================== --- linux.orig/mm/slub.c 2013-11-07 10:25:49.669706521 -0600 +++ linux/mm/slub.c 2013-11-07 10:27:49.130394661 -0600 @@ -1217,8 +1217,8 @@ static unsigned long kmem_cache_flags(un /* * Enable debugging if selected on the kernel commandline. */ - if (slub_debug && (!slub_debug_slabs || - !strncmp(slub_debug_slabs, name, strlen(slub_debug_slabs)))) + if (slub_debug && (!slub_debug_slabs || (name && + !strncmp(slub_debug_slabs, name, strlen(slub_debug_slabs))))) flags |= slub_debug;
return flags;
| |