[lkml]   [2013]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK
On 11/06/2013 10:54 AM, Borislav Petkov wrote:
> On Wed, Nov 06, 2013 at 10:15:04AM -0600, Rob Herring wrote:
>> Other maintainers disagree because it reduces build coverage.
> What possible build coverage are we talking about when building highbank
> on x86, for example? And what does a build failure in that configuration
> tell you if it builds and boots fine on your hardware?

Using some interface which is arch specific and should not be used in a
driver. We used to have tons of mach dependencies in "ARM" drivers that
took a lot of effort to clean-up. Requiring all drivers to build on
allyesconfigs would have prevented that. The same thing applies at the
architecture level. Of course there are exceptions, but if we only limit
the exceptions then they are easy to find.

>> Having done some cross arch clean-up, I have to agree with that
>> position. Iterating builds over different arches is bad enough, but
>> iterating over all configs for each arch is a pain.
> So make highbank depend only on the arches for which it is supposed to
> work but not for *all* arches. Look at how the other edac drivers do it,
> x86 ones depend on X86, tile on tile, etc, etc. Why should highbank be
> special?
>> It would be nice to have a uniform policy here.
> Simple: drivers should be selectable/buildable only on the arches
> they're supposed to run on.

Like I said, not all maintainers agree. David M rejected patches from me
restricting our network driver to ARM.


 \ /
  Last update: 2013-11-06 18:41    [W:0.066 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site