lkml.org 
[lkml]   [2013]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mm: thp: give transparent hugepage code a separate copy_page
On 11/06/2013 05:46 AM, Hillf Danton wrote:
> On Tue, Oct 29, 2013 at 6:16 AM, Dave Hansen <dave@sr71.net> wrote:
>> +
>> +void copy_high_order_page(struct page *newpage,
>> + struct page *oldpage,
>> + int order)
>> +{
>> + int i;
>> +
>> + might_sleep();
>> + for (i = 0; i < (1<<order); i++) {
>> + cond_resched();
>> + copy_highpage(newpage + i, oldpage + i);
>> + }
>> +}
>
> Can we make no use of might_sleep here with cond_resched in loop?

I'm not sure what you're saying.

Are you pointing out that cond_resched() actually calls might_sleep() so
the might_sleep() is redundant?



\
 
 \ /
  Last update: 2013-11-06 18:01    [W:0.063 / U:2.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site