Messages in this thread Patch in this message | | | Date | Wed, 6 Nov 2013 10:42:10 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 01/10] perf hists: Consolidate __hists__add_*entry() |
| |
Em Tue, Nov 05, 2013 at 09:52:43PM +0000, Rodrigo Campos escreveu: > On Tue, Nov 05, 2013 at 05:09:52PM -0300, Arnaldo Carvalho de Melo wrote: > > @@ -486,15 +425,15 @@ struct hist_entry *__hists__add_entry(struct hists *hists, > > .stat = { > > - .period = period, > > .nr_events = 1, > > + .period = period, > > .weight = weight, > > },
> Isn't this seems unrelated and unneeded ?
> The "period" field is before the "nr_events" field in the struct, so maybe is > more clear to leave it as it was ? The actual relative order (it has some more > fields) in the struct is: period, weigth, nr_events. Might be better if they > match that order here ? Although not sure since we are using the fields with > name and is clear enough.
Yeah, this shouldn't be there, I thought about fixing this up to reduce the patch size, but ended up being lenient.
Namhyung, please avoid such unneeded patch churn :-)
- Arnaldo
| |