Messages in this thread | | | Date | Tue, 05 Nov 2013 11:04:04 -0500 | From | David Long <> | Subject | Re: [PATCH] uprobes: introduce arch_uprobe->ixol |
| |
On 11/04/13 14:49, Oleg Nesterov wrote: > On 10/29, Oleg Nesterov wrote: >> >> David. Perhaps we can avoid the new hook altogether? What if we do >> the simple change below (it ignores powerpc) ? >> >> Then arm can add "unsigned long ixol[2]" into its arch_uprobe, and >> arch_uprobe_analyze_insn() can initialize this member correctly. >> >> What do you think? > > Seriouly, how about the patch below? > > In fact, given that you are going to reimplement set_swbp/orig_insn, > the new member is not strictly needed (afaics). But it looks more > clear this way, and we need s/MAX_UINSN_BYTES/sizeof()/ anyway. > > Oleg. > ---
I agree that this is cleaner than another weak callout. I have it working for ARM now.
Thanks, -dl
| |