Messages in this thread | | | Date | Mon, 4 Nov 2013 09:21:02 +0000 | From | Charles Keepax <> | Subject | Re: [PATCH v2 1/2] extcon: arizona: Fix reset of HPDET after race with removal |
| |
On Mon, Nov 04, 2013 at 09:32:50AM +0900, Chanwoo Choi wrote: > The arizona_hpdet_do_id() return only either -EAGIN or 0(zero). > extcon-arizona driver could never execute 'goto done;' statement. > > ret = arizona_hpdet_do_id(info, &reading, &mic); > if (ret == -EAGAIN) { > goto out; > } else if (ret < 0) { > goto done; > }
True that else if is redundant at the moment, but personally I would be inclined to leave it in, it feels safer against possible future edits of arizona_hpdet_do_id. It would be reasonable for someone to assume that other return values are acceptable whilst editing it but they would then not be handled.
Thanks, Charles
| |