Messages in this thread | | | From | Mathias Krause <> | Subject | [PATCHv2 0/2] IPC DoS fix | Date | Sun, 3 Nov 2013 12:36:26 +0100 |
| |
Hi Linus,
version 2 of this series uses your approach to fix the issues by changing load_msg() and friends to use a size_t for the message length. It differs slightly from your patch to cover a few more places where the message length is evaluated in sign extension problematic expressions. Also the sysctl change is still a separate patch to allow reverting it in case it breaks existing userland. It now handles all three sysctls: msgmax, msgmnb and msgmni. All still capped at INT_MAX, though. They're privileged sysctls after all. And setting them to INT_MAX does not end up in a system crash, as it is now for negative values, but in an OOM killer invocation instead which can be handled gracefully.
Regards, Mathias
Mathias Krause (2): ipc, msg: fix message length check for negative values ipc, msg: forbid negative values for "msg{max,mnb,mni}"
include/linux/ipc_namespace.h | 6 +++--- include/linux/msg.h | 6 +++--- ipc/ipc_sysctl.c | 20 ++++++++++++-------- ipc/msgutil.c | 20 ++++++++++---------- ipc/util.h | 4 ++-- 5 files changed, 30 insertions(+), 26 deletions(-)
-- 1.7.10.4
| |