lkml.org 
[lkml]   [2013]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 08/12] efi: only print saved efi runtime maps instead of all memmap ranges for kexec
    On 11/27/13 at 03:27pm, Borislav Petkov wrote:
    > On Wed, Nov 27, 2013 at 10:27:01AM +0000, Matt Fleming wrote:
    > > Heh, you can probably already guess what I'm going to say here...
    >
    > I guessed :-)
    >
    > > How about using a single function to dump the memory ranges irrespective
    > > of whether the memory map comes from 'memmap' or 'esdata'? e.g.
    > > something along the lines of,
    > >
    > > if (esdata)
    > > print_efi_memmap(esdata->map, nr_efi_runtime_map,
    > > sizeof(esdata->map[0]));
    > > else
    > > print_efi_memmap(memmap.map, memmap.nr_map,
    > > memmap.desc_size);
    >
    > And while you're at it:
    >
    > WARNING: quoted string split across lines
    > #19: FILE: arch/x86/platform/efi/efi.c:443:
    > + pr_info("mem%02u: type=%u, attr=0x%llx, "
    > + "range=[0x%016llx-0x%016llx) (%lluMB)\n",

    I see the warnings, because it's originally in print_efi_memmap so I just keep
    new function same. Anyway after switching to use one function there will be
    no such warning.

    >
    >
    > Btw, do we really want to dump the same map again in the second kernel?

    It's for debugging purpose, I think it's helpful.

    Thanks for review
    Dave


    \
     
     \ /
      Last update: 2013-11-29 10:01    [W:4.628 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site