lkml.org 
[lkml]   [2013]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [merged] mm-memcg-handle-non-error-oom-situations-more-gracefully.patch removed from -mm tree
On Thu, Nov 28, 2013 at 10:12:55AM +0100, Michal Hocko wrote:
> On Wed 27-11-13 18:33:53, Johannes Weiner wrote:
> [...]
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index 13b9d0f..5f9e467 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -2675,7 +2675,7 @@ static int __mem_cgroup_try_charge(struct mm_struct *mm,
> > goto bypass;
> >
> > if (unlikely(task_in_memcg_oom(current)))
> > - goto bypass;
> > + goto nomem;
> >
> > /*
> > * We always charge the cgroup the mm_struct belongs to.
>
> Yes, I think we really want this. Plan to send a patch? The first charge
> failure due to OOM shouldn't be papered over by a later attempt if we
> didn't get through mem_cgroup_oom_synchronize yet.

Sure thing. Will send this to Andrew on Monday.


\
 
 \ /
  Last update: 2013-11-30 05:01    [W:2.142 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site