lkml.org 
[lkml]   [2013]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2] inet: fix possible seqlock deadlocks
    From
    From: Hannes Frederic Sowa <hannes@stressinduktion.org>
    Date: Thu, 28 Nov 2013 19:09:14 +0100

    > On Thu, Nov 28, 2013 at 09:51:22AM -0800, Eric Dumazet wrote:
    >> From: Eric Dumazet <edumazet@google.com>
    >>
    >> In commit c9e9042994d3 ("ipv4: fix possible seqlock deadlock") I left
    >> another places where IP_INC_STATS_BH() were improperly used.
    >>
    >> udp_sendmsg(), ping_v4_sendmsg() and tcp_v4_connect() are called from
    >> process context, not from softirq context.
    >>
    >> This was detected by lockdep seqlock support.
    >>
    >> Reported-by: jongman heo <jongman.heo@samsung.com>
    >> Fixes: 584bdf8cbdf6 ("[IPV4]: Fix "ipOutNoRoutes" counter error for TCP and UDP")
    >> Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind")
    >> Signed-off-by: Eric Dumazet <edumazet@google.com>
    >> Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
    >
    > Just got home after getting distracted with other things today and the work is
    > already done. Thanks, Eric! ;)
    >
    > Exactly the spots I noticed this morning, so
    >
    > Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

    Applied and queued up for -stable.


    \
     
     \ /
      Last update: 2013-11-29 23:01    [W:2.084 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site