lkml.org 
[lkml]   [2013]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/34] perf trace: Remove thread summary coloring
    Date
    From: Pekka Enberg <penberg@kernel.org>

    Thread summary line coloring looks ugly. It doesn't add much value so
    remove coloring completely.

    Signed-off-by: Pekka Enberg <penberg@kernel.org>
    Acked-by: David Ahern <dsahern@gmail.com>
    Link: http://lkml.kernel.org/r/1384447410-1771-1-git-send-email-penberg@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-trace.c | 13 ++-----------
    1 file changed, 2 insertions(+), 11 deletions(-)

    diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
    index 8be17fc462ba..e9f345e2551a 100644
    --- a/tools/perf/builtin-trace.c
    +++ b/tools/perf/builtin-trace.c
    @@ -2158,7 +2158,6 @@ static int trace__fprintf_one_thread(struct thread *thread, void *priv)
    size_t printed = data->printed;
    struct trace *trace = data->trace;
    struct thread_trace *ttrace = thread->priv;
    - const char *color;
    double ratio;

    if (ttrace == NULL)
    @@ -2166,17 +2165,9 @@ static int trace__fprintf_one_thread(struct thread *thread, void *priv)

    ratio = (double)ttrace->nr_events / trace->nr_events * 100.0;

    - color = PERF_COLOR_NORMAL;
    - if (ratio > 50.0)
    - color = PERF_COLOR_RED;
    - else if (ratio > 25.0)
    - color = PERF_COLOR_GREEN;
    - else if (ratio > 5.0)
    - color = PERF_COLOR_YELLOW;
    -
    - printed += color_fprintf(fp, color, " %s (%d), ", thread__comm_str(thread), thread->tid);
    + printed += fprintf(fp, " %s (%d), ", thread__comm_str(thread), thread->tid);
    printed += fprintf(fp, "%lu events, ", ttrace->nr_events);
    - printed += color_fprintf(fp, color, "%.1f%%", ratio);
    + printed += fprintf(fp, "%.1f%%", ratio);
    printed += fprintf(fp, ", %.3f msec\n", ttrace->runtime_ms);
    printed += thread__dump_stats(ttrace, trace, fp);

    --
    1.8.1.4


    \
     
     \ /
      Last update: 2013-11-27 22:41    [W:4.162 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site