Messages in this thread | | | Date | Tue, 26 Nov 2013 23:04:06 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH v3 1/6] watchdog: davinci: change driver to use WDT core |
| |
On 11/26/2013 08:31 PM, Sekhar Nori wrote: > On Monday 25 November 2013 07:34 PM, Ivan Khoronzhuk wrote: >> To reduce code duplicate and increase code readability use WDT core >> code to handle WDT interface. >> >> Remove io_lock as the WDT core uses mutex to lock each wdt device. >> Remove wdt_state as the WDT core tracks state with its own variable. >> >> The watchdog_init_timeout() can read timeout value from timeout-sec >> property if the passed value is out of bounds. The heartbeat is >> initialized in next way. If heartbeat is not set thought module >> parameter, try to read it's value from WDT node timeout-sec property. >> If node has no one, use default value. >> >> The heartbeat is hold in wdd->timeout by WDT core, so use it in >> order to set timeout period. >> >> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com> >> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > So this still causes a regression because the clk_get() > fails due to the changed device name. Please fold this > patch in (tested on DM365, compiled on rest). > > Also, the change in device name (while needed) does not seem > to be related to usage of wdt core. Can you may be split > that change into a separate patch? >
Given all the trouble with it, I think that would be a good idea.
Guenter
| |