lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 19/80] PCI: Support PCIe Capability Slot registers only for ports with slots
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bjorn Helgaas <bhelgaas@google.com>

    commit 6d3a1741f1e648cfbd5a0cc94477a0d5004c6f5e upstream.

    Previously we allowed callers to access Slot Capabilities, Status, and
    Control for Root Ports even if the Root Port did not implement a slot.
    This seems dubious because the spec only requires these registers if a
    slot is implemented.

    It's true that even Root Ports without slots must have *space* for these
    slot registers, because the Root Capabilities, Status, and Control
    registers are after the slot registers in the capability. However,
    for a v1 PCIe Capability, the *semantics* of the slot registers are
    undefined unless a slot is implemented.

    Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
    Reviewed-By: Jiang Liu <jiang.liu@huawei.com>
    Acked-by: Myron Stowe <myron.stowe@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/pci/access.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/pci/access.c
    +++ b/drivers/pci/access.c
    @@ -497,9 +497,9 @@ static inline bool pcie_cap_has_sltctl(c
    {
    int type = pci_pcie_type(dev);

    - return type == PCI_EXP_TYPE_ROOT_PORT ||
    - (type == PCI_EXP_TYPE_DOWNSTREAM &&
    - pcie_caps_reg(dev) & PCI_EXP_FLAGS_SLOT);
    + return (type == PCI_EXP_TYPE_ROOT_PORT ||
    + type == PCI_EXP_TYPE_DOWNSTREAM) &&
    + pcie_caps_reg(dev) & PCI_EXP_FLAGS_SLOT;
    }

    static inline bool pcie_cap_has_rtctl(const struct pci_dev *dev)



    \
     
     \ /
      Last update: 2013-11-27 05:21    [W:4.081 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site