Messages in this thread | | | Date | Tue, 26 Nov 2013 09:26:26 +0100 | From | Peter Zijlstra <> | Subject | Re: Add memory barrier when waiting on futex |
| |
On Tue, Nov 26, 2013 at 01:07:25AM +0000, Ma, Xindong wrote: > I've already aware that they've protected by spinlock, this is why I adding a memory barrier to fix it.
That doesn't make sense.. the spinlocks should provide the required serialization, there's nothing to fix.
> I reproduced this issue several times on android which running on IA dual core.
I think you need to be more specific, in particular, if spinlocks do not provide serialization on your IA32 device, I'd call that thing broken. Adding random memory barriers is _WRONG_.
| |