lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 086/116] powerpc/mpc512x: silence build warning upon disabled DIU
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gerhard Sittig <gsi@denx.de>

    commit 45d20e8348969a165c53cfb91f445e7cc599a9f0 upstream.

    a disabled Kconfig option results in a reference to a not implemented
    routine when the IS_ENABLED() macro is used for both conditional
    implementation of the routine as well as a C language source code test
    at the call site -- the "if (0) func();" construct only gets eliminated
    later by the optimizer, while the compiler already has emitted its
    warning about "func()" being undeclared

    provide an empty implementation for the mpc512x_setup_diu() and
    mpc512x_init_diu() routines in case of the disabled option, to avoid the
    compiler warning which is considered fatal and breaks compilation

    the bug appeared with commit 2abbbb63c90ab55ca3f054772c2e5ba7df810c48
    "powerpc/mpc512x: move common code to shared.c file", how to reproduce:

    make mpc512x_defconfig
    echo CONFIG_FB_FSL_DIU=n >> .config && make olddefconfig
    make

    CC arch/powerpc/platforms/512x/mpc512x_shared.o
    .../arch/powerpc/platforms/512x/mpc512x_shared.c: In function 'mpc512x_init_early':
    .../arch/powerpc/platforms/512x/mpc512x_shared.c:456:3: error: implicit declaration of function 'mpc512x_init_diu' [-Werror=implicit-function-declaration]
    .../arch/powerpc/platforms/512x/mpc512x_shared.c: In function 'mpc512x_setup_arch':
    .../arch/powerpc/platforms/512x/mpc512x_shared.c:469:3: error: implicit declaration of function 'mpc512x_setup_diu' [-Werror=implicit-function-declaration]
    cc1: all warnings being treated as errors
    make[4]: *** [arch/powerpc/platforms/512x/mpc512x_shared.o] Error 1

    Signed-off-by: Gerhard Sittig <gsi@denx.de>
    Signed-off-by: Anatolij Gustschin <agust@denx.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/powerpc/platforms/512x/mpc512x_shared.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/arch/powerpc/platforms/512x/mpc512x_shared.c
    +++ b/arch/powerpc/platforms/512x/mpc512x_shared.c
    @@ -303,6 +303,9 @@ void __init mpc512x_setup_diu(void)
    diu_ops.release_bootmem = mpc512x_release_bootmem;
    }

    +#else
    +void __init mpc512x_setup_diu(void) { /* EMPTY */ }
    +void __init mpc512x_init_diu(void) { /* EMPTY */ }
    #endif

    void __init mpc512x_init_IRQ(void)



    \
     
     \ /
      Last update: 2013-11-27 02:41    [W:4.077 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site