lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain
On 11/26/13, 7:20 AM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 26, 2013 at 12:52:21PM +0200, Adrian Hunter escreveu:
>> On 25/11/13 16:17, Arnaldo Carvalho de Melo wrote:
>>> From: David Ahern <dsahern@gmail.com>
>>> } else {
>>> + if (al.sym->ignore)
>>
>> Seems to segfault here because sym is null
>>
>>> + return;
>>> +
>
> Changed it to look at (al.sym && al.sym->ignore), the rest of the code
> already checkfs if al.sym is NULL (printing [unknown], etc), can you
> please take a look at:
>
> https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=c0dd57452349779e0e5d436db8f9448dfffcc512
>
> In an updated acme/perf/core branch?
>

Looks good to me. That's what I was going to send you. Sorry for the noise.

David



\
 
 \ /
  Last update: 2013-11-26 15:41    [W:0.990 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site