Messages in this thread | | | Subject | Re: [PATCH] pipe_to_sendpage: Ensure that MSG_MORE is set if we set MSG_SENDPAGE_NOTLAST | From | Eric Dumazet <> | Date | Mon, 25 Nov 2013 16:02:00 -0800 |
| |
On Mon, 2013-11-25 at 08:42 +0100, Richard Weinberger wrote:
> In the commit message of your patch you wrote "For all sendpage() providers, > its a transparent change.". Why does AF_ALG need special handling? > If users have to care about MSG_SENDPAGE_NOTLAST it is no longer really an > internal flag.
MSG_SENDPAGE_NOTLAST is an internal (kernel) flag.
Fact that I missed some MSG_MORE 'users' in the kernel was an oversight.
I am not saying your patch is not needed, I am only saying it reverts a useful TCP optimization, and we can do better, dont we ?
| |