lkml.org 
[lkml]   [2013]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v6 1/6] gpio: davinci: use readl/writel instead of __raw_*
    Hi Taras,

    On Fri, Nov 22, 2013 at 3:38 PM, Taras Kondratiuk
    <taras.kondratiuk@linaro.org> wrote:
    > On 21 November 2013 20:15, Prabhakar Lad <prabhakar.csengg@gmail.com> wrote:
    >> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
    >>
    >> This patch replaces the __raw_readl/writel with
    >> readl and writel, Altough the code runs on ARMv5
    >> based SOCs, changing this will help copying the code
    >> for other uses.
    >
    > This replacement has a functional impact: it adds memory barriers.
    > Please note this in the description.
    > Also please add a bit of explanation on why do you need to add barriers.
    >
    Agreed this adds memory barriers, I'll add a note about it.

    Thanks,
    --Prabhakar Lad


    \
     
     \ /
      Last update: 2013-11-25 05:41    [W:4.417 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site