lkml.org 
[lkml]   [2013]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist
(2013/11/21 16:29), Ingo Molnar wrote:
>
> * Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>> (2013/11/21 2:36), Frank Ch. Eigler wrote:
>
> [ ... ]
>>> one needs to resort to something like:
>>>
>>> # cat /proc/kallsyms | grep ' [tT] ' | while read addr type symbol; do
>>> perf probe $symbol
>>> done
>>>
>>> then wait for a few hours for that to finish. Then, or while the loop
>>> is still running, run
>>>
>>> # perf record -e 'probe:*' -aR sleep 1
>>>
>>> to take a kernel down.
>>
>> Um, indeed, current blacklist is not perfect. [...]
>
> Then it needs to be fixed ASAP!

OK, I see. At least the two patches included this series
should be fixed. :)

And more, I need to test all symbols and drills down.

>> [...] As I reported in this series, I've found 2 more patterns. I
>> guess there still have some others.
>>
>> But anyway, I don't think it is good to fix all such bugs in this
>> series.
>
> Fixing these bugs is far more important than any cleanup work.

I see. This cleanup started with the bugfixes :)

> We can apply the fixes together with your cleanup series to make it
> all simpler, but the bug fixing absolutely needs to happen right now.

OK, I'll test it first and include the bugfixes in this series.
Or should I push the fixes separated?

Thank you,

--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com




\
 
 \ /
  Last update: 2013-11-22 04:01    [W:0.206 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site