lkml.org 
[lkml]   [2013]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/6] kexec-bzImage: Support for loading bzImage using 64bit entry
    On Thu, Nov 21, 2013 at 11:07:10AM -0800, Greg KH wrote:
    > On Wed, Nov 20, 2013 at 12:50:50PM -0500, Vivek Goyal wrote:
    > > This is loader specific code which can load bzImage and set it up for
    > > 64bit entry. This does not take care of 32bit entry or real mode entry
    > > yet.
    > >
    > > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
    > > ---
    > > arch/x86/include/asm/kexec-bzimage.h | 12 +
    > > arch/x86/include/asm/kexec.h | 26 +++
    > > arch/x86/kernel/Makefile | 2 +
    > > arch/x86/kernel/kexec-bzimage.c | 375 ++++++++++++++++++++++++++++++++++
    > > arch/x86/kernel/machine_kexec_64.c | 4 +-
    > > arch/x86/kernel/purgatory_entry_64.S | 119 +++++++++++
    > > 6 files changed, 537 insertions(+), 1 deletions(-)
    > > create mode 100644 arch/x86/include/asm/kexec-bzimage.h
    > > create mode 100644 arch/x86/kernel/kexec-bzimage.c
    > > create mode 100644 arch/x86/kernel/purgatory_entry_64.S
    >
    > Wow, that's surprisingly small, nice job.
    >
    > What do you mean by the "real mode entry"? Do we need to care about
    > that because we aren't falling back to real mode when executing this,
    > are we? Or does that just happen for 32bit kernels?

    Original kexec offers real mode entry choice too. So we fall back
    to real mode and jump to kernel and kernel makes bunch of BIOS calls. I
    don't think this is a commonly used option.

    For 32bit kernels, currently by default we use 32bit entry point of
    bzImage and we don't drop to real mode. Real mode entry is forced
    by user using command line option --real-mode to kexec-tools.

    So this is one of the features of existing kexec-tools I just wanted
    to make it explicitly clear that I have not taken care of that feature
    as it is not a commonly used one. If somebody needs it, they can implement
    it.

    Thanks
    Vivek


    \
     
     \ /
      Last update: 2013-11-21 20:41    [W:4.123 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site