Messages in this thread | | | Date | Thu, 21 Nov 2013 10:37:54 +0000 | From | David Vrabel <> | Subject | Re: [PATCH 1/4] xen/mcfg: Call PHYSDEVOP_pci_mmcfg_reserved for MCFG areas. |
| |
On 08/11/13 17:38, Konrad Rzeszutek Wilk wrote: > The PCI MMCONFIG area is usually reserved via the E820 so the Xen hypervisor > is aware of these regions. But they can also be enumerated in the ACPI > DSDT which means the hypervisor won't know of them until the initial > domain informs it of via PHYSDEVOP_pci_mmcfg_reserved. > > This is what this patch does for all of the MCFG regions that the > initial domain is aware of (E820 enumerated and ACPI). > > Reported-by: Santosh Jodh <Santosh.Jodh@citrix.com> > CC: Jan Beulich <JBeulich@suse.com> > CC: Boris Ostrovsky <boris.ostrovsky@oracle.com> > CC: David Vrabel <david.vrabel@citrix.com> > CC: Mukesh Rathor <mukesh.rathor@oracle.com> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
> [v1: Redid it a bit] > [v2: Dropped the P2M 1-1 setting] > [v3: Check for Xen in-case we are running under baremetal] > [v4: Wrap with CONFIG_PCI_MMCONFIG]
This sort of change list isn't useful in the long term. I'd prefer it if this was after the --- divider.
> --- a/drivers/xen/pci.c > +++ b/drivers/xen/pci.c > @@ -26,6 +26,7 @@ > + default: > + pr_warn("Failed to report MMCONFIG reservation" > + " state for %s to hypervisor" > + " (%d)\n",
Message strings shouldn't be split like this.
David
| |