Messages in this thread | | | Date | Sat, 16 Nov 2013 17:24:11 -0700 | From | Jason Gunthorpe <> | Subject | Re: [tpmdd-devel] [PATCH 2/5 v2] tpm: Pull everything related to sysfs into tpm-sysfs.c |
| |
On Sat, Nov 16, 2013 at 05:53:19PM -0600, Ashley Lai wrote:
> > +/* XXX for now this helper is duplicated in tpm.c */ > > I think you mean this is duplicated in tpm-interface.c. Is there a > reason why we cannot add this to tpm.h to avoid this duplication?
Indeed, it was called tpm.c when I wrote it :)
I left it because I think there should be a public API to send a command that makes sense, and transmit_cmd is not good. But, that can come later, so lets share them for now.
> > +static ssize_t transmit_cmd(struct tpm_chip *chip, struct tpm_cmd_t *cmd, > > + int len, const char *desc) > > +{ > > > > +static ssize_t pubek_show(struct device *dev, struct device_attribute *attr, > > + char *buf) > > Most of the functions in this file are moved from tpm-interface.c > without any modification to the code. Why do we need to change the > function names in this file? Unless there is a good reason for it > otherwise I would prefer to keep the same function names.
When I did the sysfs attribute lists in this file I used the modern sysfs macros:
>> +static DEVICE_ATTR_RO(pubek);
Which are safer to use, but do require the function name to match the sysfs file name.
So all sysfs functions must be in the form <FILENAME>_show.
Jason
| |