Messages in this thread Patch in this message | | | From | David Howells <> | Subject | Re: [PATCH 9/9] KEYS: Fix encrypted key type update method | Date | Thu, 14 Nov 2013 17:59:51 +0000 |
| |
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> Is there a keyutils git repo with a version of keyctl that supports the > control option?
http://git.kernel.org/cgit/linux/kernel/git/dhowells/keyutils.git/log/?h=development
> - type size_t is unsigned, no need to verify that it is negative.
It doesn't hurt either...
> - missing Documentation/security/keys-trusted-encrypted.txt updates
Fixed (see diff below), but I suspect trusted_update() also needs scrutiny.
> - the encrypted_preparse() comment still says 'encrypted_instantiate'
Fixed.
David --- diff --git a/Documentation/security/keys-trusted-encrypted.txt b/Documentation/security/keys-trusted-encrypted.txt index e105ae97a4f5..78794adf445d 100644 --- a/Documentation/security/keys-trusted-encrypted.txt +++ b/Documentation/security/keys-trusted-encrypted.txt @@ -61,7 +61,7 @@ Usage: keyctl add encrypted name "new [format] key-type:master-key-name keylen" ring keyctl add encrypted name "load hex_blob" ring - keyctl update keyid "update key-type:master-key-name" + keyctl control keyid encrypted change-master-key "key-type:master-key-name" format:= 'default | ecryptfs' key-type:= 'trusted' | 'user'
| |