Messages in this thread Patch in this message | | | Date | Wed, 13 Nov 2013 00:26:09 +0100 | From | Ingo Molnar <> | Subject | Re: perf top -u <uid> does not seem to be working |
| |
an unrelated bug is a missing newline if the 'uid' is invalid:
hubble:~> perf top --stdio -u help Error: Invalid User: helphubble:~>
Fixed by the patch below.
comet:~/tip/tools/perf> perf top --stdio -u help Error: Invalid User: help comet:~/tip/tools/perf>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
tools/perf/builtin-top.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index b8f8e29..71e6402 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -1172,7 +1172,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) status = target__validate(target); if (status) { target__strerror(target, status, errbuf, BUFSIZ); - ui__warning("%s", errbuf); + ui__warning("%s\n", errbuf); } status = target__parse_uid(target); @@ -1180,7 +1180,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) int saved_errno = errno; target__strerror(target, status, errbuf, BUFSIZ); - ui__error("%s", errbuf); + ui__error("%s\n", errbuf); status = -saved_errno; goto out_delete_evlist;
| |