Messages in this thread | | | Date | Mon, 11 Nov 2013 10:37:47 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf record: Delete file if a failure occurs writing the perf data file |
| |
* David Ahern <dsahern@gmail.com> wrote:
> If perf fails to write data to the data file (e.g., ENOSPC error) it fails > with the message: > failed to write perf data, error: No space left on device > > and stops — killing the workload too. The file is an unknown state. > Trying to read it (e.g., perf report) fails with a SIGBUS error.
Ouch - guys please first investiage that SIGBUS, we should not behave unexpectedly on _any_ (read: random) perf.data file contents. The SIGBUS likely suggests that the parsing isn't robust enough.
> Fix by deleting the file on a failure.
That only works around the issue - if the same data file is produced by some other method (or maliciously) then perf report will still SIGBUS ...
Thanks,
Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |