lkml.org 
[lkml]   [2013]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0/2] genirq: arm64: perf: support for percpu pmu interrupt
From
On Sat, Nov 9, 2013 at 6:34 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 11/06/13 04:07, Vinayak Kale wrote:
>> This patch series adds support to handle interrupt registration/deregistration
>> in arm64 pmu driver when pmu interrupt type is percpu.
>>
>> Patches in this patch series were previously sent out as separate patches [1].
>> This patch series incorporates comments/fixes suggested for original patches.
>>
>> [1]
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-October/205888.html
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-October/204414.html
>>
>> Vinayak Kale (2):
>> genirq: error reporting in request_percpu_irq() and
>> request_threaded_irq()
>> arm64: perf: add support for percpu pmu interrupt
>>
>> arch/arm64/kernel/perf_event.c | 109 +++++++++++++++++++++++++++++-----------
>> kernel/irq/manage.c | 12 +++--
>> 2 files changed, 89 insertions(+), 32 deletions(-)
>>
>
> What ever happened to the approach here[1]? It doesn't look very nice to
> have to request the irq first as a per-cpu interrupt and then try as a
> non-percpu interrupt when genirq already knows if its per-cpu or not.
>
> [1] http://lkml.indiana.edu/hypermail/linux/kernel/1207.3/02955.html
I don't see any discussions on mailing list on approach taken in above patch.

IMO, if fixing up minor error reporting in existing functions can do
the job then we should avoid adding a new function.


\
 
 \ /
  Last update: 2013-11-11 10:41    [W:0.124 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site