lkml.org 
[lkml]   [2013]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drivers: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO
From
On 11/01/2013 06:09 PM, Duan Jiong wrote:
> This patch fixes coccinelle error regarding usage of IS_ERR and
> PTR_ERR instead of PTR_ERR_OR_ZERO.
>
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
> ---
> drivers/misc/carma/carma-fpga.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/misc/carma/carma-fpga.c b/drivers/misc/carma/carma-fpga.c
> index 08b18f3..9a32e98 100644
> --- a/drivers/misc/carma/carma-fpga.c
> +++ b/drivers/misc/carma/carma-fpga.c
> @@ -956,10 +956,7 @@ static int data_debugfs_init(struct fpga_device *priv)
> {
> priv->dbg_entry = debugfs_create_file(drv_name, S_IRUGO, NULL, priv,
> &data_debug_fops);
> - if (IS_ERR(priv->dbg_entry))
> - return PTR_ERR(priv->dbg_entry);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(priv->dbg_entry);
> }

Those code has make sure that CONFIG_DEBUG_FS is enabled, so
debugfs_create_file() never return PTR_ERR(), only NULL will
be returned when error occurs.





\
 
 \ /
  Last update: 2013-11-11 09:01    [W:0.059 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site