Messages in this thread | | | Date | Mon, 11 Nov 2013 14:54:30 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/3] panic: enable local IRQs for restart timeout too |
| |
* Felipe Contreras <felipe.contreras@gmail.com> wrote:
> On Mon, Nov 11, 2013 at 7:19 AM, Ingo Molnar <mingo@kernel.org> wrote: > > > > * Felipe Contreras <felipe.contreras@gmail.com> wrote: > > > >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> > > > > The changelog is missing and the title is not self-explanatory. > > Either the local IRQs should be enabled for both the restart and halt > blinks, or it shouldn't be enabled for either. Why enable them for > halt, but not restart? > > I think enabling them for restart too makes sense.
Such arguments belong into the changelog, with a description of what was done before and what is done after - please use the customary (verbose) changelog style we use in the kernel.
Thanks,
Ingo
| |