lkml.org 
[lkml]   [2013]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 28/66] farsync: fix info leak in ioctl
    Date
    3.11-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Salva Peiró <speiro@ai2.upv.es>

    [ Upstream commit 96b340406724d87e4621284ebac5e059d67b2194 ]

    The fst_get_iface() code fails to initialize the two padding bytes of
    struct sync_serial_settings after the ->loopback member. Add an explicit
    memset(0) before filling the structure to avoid the info leak.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/wan/farsync.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/wan/farsync.c
    +++ b/drivers/net/wan/farsync.c
    @@ -1972,6 +1972,7 @@ fst_get_iface(struct fst_card_info *card
    }

    i = port->index;
    + memset(&sync, 0, sizeof(sync));
    sync.clock_rate = FST_RDL(card, portConfig[i].lineSpeed);
    /* Lucky card and linux use same encoding here */
    sync.clock_type = FST_RDB(card, portConfig[i].internalClock) ==

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-11-02 00:01    [W:3.677 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site