lkml.org 
[lkml]   [2013]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 29/66] unix_diag: fix info leak
    Date
    3.11-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mathias Krause <minipli@googlemail.com>

    [ Upstream commit 6865d1e834be84ddd5808d93d5035b492346c64a ]

    When filling the netlink message we miss to wipe the pad field,
    therefore leak one byte of heap memory to userland. Fix this by
    setting pad to 0.

    Signed-off-by: Mathias Krause <minipli@googlemail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/unix/diag.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/unix/diag.c
    +++ b/net/unix/diag.c
    @@ -124,6 +124,7 @@ static int sk_diag_fill(struct sock *sk,
    rep->udiag_family = AF_UNIX;
    rep->udiag_type = sk->sk_type;
    rep->udiag_state = sk->sk_state;
    + rep->pad = 0;
    rep->udiag_ino = sk_ino;
    sock_diag_save_cookie(sk, rep->udiag_cookie);




    \
     
     \ /
      Last update: 2013-11-02 00:01    [W:4.507 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site