lkml.org 
[lkml]   [2013]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/6] perf timechart: use proc_num to implement --power-only
Date
On Tue, 29 Oct 2013 13:28:46 +0400, Stanislav Fomichev wrote:
>> I don't see how it does same thing. You mean it by skipping
>> draw_process_bars() and draw_wakeups() on patch 1? It'd be better
>> changelog explains the details.
> Yes, it depends on the previous patch, I'll add more info to the
> changelog.

If so, I think it'd better moving the if () parts into this patch.

Thanks,
Namhyung

>
>> And I'd like to keep it as BOOLEAN option - it's simpler and more
>> straight-forward IMHO.
>>
>> How about adding
>>
>> if (power_only)
>> proc_num = 0;
>>
>> after parsing the command line options?
> Ok, this works too.


\
 
 \ /
  Last update: 2013-11-01 07:41    [W:0.116 / U:2.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site