Messages in this thread Patch in this message | | | From | "Geyslan G. Bem" <> | Subject | [PATCH v4] btrfs: Fix memory leakage in the tree-log.c | Date | Wed, 9 Oct 2013 23:01:35 -0300 |
| |
When 'dir' is NULL, after calling extref_get_fields(), add_inode_ref() can be returning without freeing the 'name' pointer.
Added kfree when necessary.
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> --- fs/btrfs/tree-log.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index 79f057c..63c0b72 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -1169,8 +1169,11 @@ static noinline int add_inode_ref(struct btrfs_trans_handle *trans, */ if (!dir) dir = read_one_inode(root, parent_objectid); - if (!dir) + if (!dir) { + if (!ret) + kfree(name); return -ENOENT; + } } else { ret = ref_get_fields(eb, ref_ptr, &namelen, &name, &ref_index); -- 1.8.4
| |