lkml.org 
[lkml]   [2013]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 tip/core/rcu 05/13] decnet: Apply rcu_access_pointer() to avoid sparse false positive
On Wed, Oct 09, 2013 at 03:46:04PM -0700, Paul E. McKenney wrote:
> On Wed, Oct 09, 2013 at 03:28:42PM -0700, Josh Triplett wrote:
> > On Wed, Oct 09, 2013 at 02:29:38PM -0700, Paul E. McKenney wrote:
> > > From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> > >
> > > The sparse checking for rcu_assign_pointer() was recently upgraded
> > > to reject non-__kernel address spaces. This also rejects __rcu,
> > > which is almost always the right thing to do. However, the use in
> > > dn_insert_route() is legitimate: It is assigning a pointer to an element
> >
> > Nit: "uses ... are", not "use ... is". :)
>
> Don't I already have "use ... is"?

I was suggesting that it needed to change from "use ... is" to "uses ...
are", not the other way around.

- Josh Triplett


\
 
 \ /
  Last update: 2013-10-10 01:21    [W:0.093 / U:25.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site