[lkml]   [2013]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] rcar-hpbdma: remove shdma_free_irq() calls

On 03-10-2013 6:00, Simon Horman wrote:

>>> Commit c1c63a14f4f2419d093acd7164eccdff315baa86 (DMA: shdma: switch to managed
>>> resource allocation) got rid of shdma_free_irq() but unfortunately got merged
>>> later than commit c4f6c41ba790bbbfcebb4c47a709ac8ff1fe1af9 (dma: add driver for
>>> R-Car HPB-DMAC), so that the HPB-DMAC driver retained the calls and got broken:

>>> drivers/dma/sh/rcar-hpbdma.c: In function `hpb_dmae_alloc_chan_resources':
>>> drivers/dma/sh/rcar-hpbdma.c:435: error: implicit declaration of function
>>> `shdma_free_irq'

>>> Fix this compilation error by removing the remaining shdma_free_irq() calls.

>> Tested-by: Simon Horman <>

>>> Reported-by: Simon Horman <>
>>> Signed-off-by: Sergei Shtylyov <>

> Vinod, could you consider taking this and the following patch
> as a fix for v3.12?

Vinod, may I ask when these regression (induced by you) fixes gets merged?

WBR, Sergei

 \ /
  Last update: 2013-10-09 19:41    [W:0.050 / U:2.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site