lkml.org 
[lkml]   [2013]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/16] sched/wait: Collapse __wait_event macros -v5
On Wed, Oct 09, 2013 at 08:08:06AM +0200, Ingo Molnar wrote:
>
> * Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
>
> > On Tue, Oct 08, 2013 at 08:28:43PM -0700, Paul E. McKenney wrote:
> > > On Tue, Oct 08, 2013 at 01:40:56PM -0700, Paul E. McKenney wrote:
> > > > On Tue, Oct 08, 2013 at 09:47:18PM +0200, Ingo Molnar wrote:
> >
> > [ . . . ]
> >
> > > > > > Should I be thinking about making a kernel/rcu?
> > > > >
> > > > > I wanted to raise it with you at the KS :-)
> > > >
> > > > Sorry for jumping the gun. ;-)
> > > >
> > > > > To me it would sure look nice to have kernel/rcu/tree.c,
> > > > > kernel/rcu/tiny.c, kernel/rcu/core.c, etc.
> > > > >
> > > > > [ ... and we would certainly also break new ground by introducing a
> > > > > "torture.c" file, for the first time in Linux kernel history! ;-) ]
> > > >
> > > > Ooh... I had better act fast! ;-)
> > > >
> > > > > But it's really your call, this is something you should only do if you are
> > > > > comfortable with it.
> > > >
> > > > I have actually been thinking about it off and on for some time.
> > >
> > > And here is a first cut. Just the renaming and needed adjustments,
> > > no splitting or merging of files.
> > >
> > > Thoughts?
> >
> > Wow! I rebased my commits destined for 3.14 on top of this, and "git
> > rebase" did it with several protests, but with no manual intervention
> > required.
>
> Git is cool!

I have indeed learned to love it through a long series of experiences
like this! ;-)

> > Now if it actually still builds, boots, and runs... ;-)
>
> Booting is overrated! ;-)

Well, some work is needed on this front, but will get there.

> Seriously, this is good stuff.
>
> Reviewed-by: Ingo Molnar <mingo@kernel.org>

Very good, I have added this.

> I'd definitely argue in favor of doing a mechanical move first, then any
> further reorganization separately.
>
> (One minor detail I noticed: you'll probably need to update the RCU file
> patterns in MAINTAINERS as well.)

Ah, good point, fixed!

Thanx, Paul



\
 
 \ /
  Last update: 2013-10-09 16:41    [W:0.079 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site