lkml.org 
[lkml]   [2013]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf record: mmap output file - RFC
On 10/9/13 7:33 AM, Jiri Olsa wrote:
>> +
>> + if (size > remaining) {
>> + memcpy(rec->mmap_addr + rec->mmap_offset, buf, remaining);
>> + rec->bytes_written += remaining;
>> +
>> + size -= remaining;
>> + buf += remaining;
>> +
>> + msync(rec->mmap_addr, rec->mmap_size, MS_ASYNC);
>> + munmap(rec->mmap_addr, rec->mmap_size);
>
> do we need msync call if munmap is called right away?

I was being overly cautious. I will remove it in v2.

David


\
 
 \ /
  Last update: 2013-10-09 16:01    [W:0.105 / U:4.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site