Messages in this thread | | | Date | Wed, 09 Oct 2013 07:46:51 -0600 | From | David Ahern <> | Subject | Re: [PATCH] perf record: mmap output file - RFC |
| |
On 10/9/13 7:33 AM, Jiri Olsa wrote: >> + >> + if (size > remaining) { >> + memcpy(rec->mmap_addr + rec->mmap_offset, buf, remaining); >> + rec->bytes_written += remaining; >> + >> + size -= remaining; >> + buf += remaining; >> + >> + msync(rec->mmap_addr, rec->mmap_size, MS_ASYNC); >> + munmap(rec->mmap_addr, rec->mmap_size); > > do we need msync call if munmap is called right away?
I was being overly cautious. I will remove it in v2.
David
| |