lkml.org 
[lkml]   [2013]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/63] Basic scheduler support for automatic NUMA balancing V9

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, Oct 09, 2013 at 01:03:54PM +0200, Ingo Molnar wrote:
> > kernel/sched/fair.c:819:22: warning: 'task_h_load' declared 'static' but never defined [-Wunused-function]
>
> Not too pretty, but it avoids the warning:
>
> ---
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -681,6 +681,8 @@ static u64 sched_vslice(struct cfs_rq *c
> }
>
> #ifdef CONFIG_SMP
> +static unsigned long task_h_load(struct task_struct *p);
> +
> static inline void __update_task_entity_contrib(struct sched_entity *se);
>
> /* Give new task start runnable values to heavy its load in infant time */
> @@ -816,8 +818,6 @@ update_stats_curr_start(struct cfs_rq *c
> * Scheduling class queueing methods:
> */
>
> -static unsigned long task_h_load(struct task_struct *p);
> -
> #ifdef CONFIG_NUMA_BALANCING

Hm, so we really want to do a split-up of this file once things have
calmed down - that will address such dependency issues.

Until then this fix will do, I've backmerged it to the originating patch.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-09 15:21    [W:0.073 / U:6.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site