[lkml]   [2013]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V4 1/3] mfd: add support for ams AS3722 PMIC
On 10/02/2013 09:50 AM, Laxman Dewangan wrote:
> The ams AS3722 is a compact system PMU suitable for mobile phones,
> tablets etc. It has 4 DC/DC step-down regulators, 3 DC/DC step-down
> controller, 11 LDOs, RTC, automatic battery, temperature and
> over-current monitoring, 8 GPIOs, ADC and a watchdog.

> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt

> + The first cell is the IRQ number.

Which IRQ number exist? Perhaps the IRQ IDs match some specific HW register?

> +Pinmux and GPIO:

> +- pinctrl-names: A pinctrl state named "default" must be defined, using the
> + bindings in pinctrl/pinctrl-binding.txt.

Why is the DT required to define a default state? If the board doesn't
need to set up any pinctrl settings, surely it shouldn't have to define
the default state.

> +- pinctrl[0...n]: Nodes for pin control to represents state 0 to state n.

These aren't nodes. Those are properties that contain phandles that
refer to nodes.

> + Each of these nodes contains different subnodes to represents
> + some desired configuration for a list of pins. This configuration can
> + include the mux function to select on those pin(s), and various pin
> + configuration parameters, such as pull-up, open drain.

What contains "these nodes"?

> +
> +Each subnode have following properties:
> +Required properties:
> + pins: List of pins. Valid options for pins properties are
> + gpio0, gpio1, gpio2, gpio3, gpio4, gpio5, gpio6, gpio7
> +
> +Optional properties:
> + Optional properties are

Why repeat that?

> + function, bias-disable, bias-pull-up, bias-pull-down,
> + bias-high-impedance, drive-open-drain.
> +
> + Valid options for funtion properties are:


I would say "values" not "options", as I think I pointed out before, but
I supopse I don't care.

> +Optional sub nodes:

The following might make it clear where these optional nodes sit:

Optional sub nodes of "regulators":

> + Additional custom properties are listed below.

Required or optional?

 \ /
  Last update: 2013-10-09 04:41    [W:0.150 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site